Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated items #881

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Remove deprecated items #881

merged 1 commit into from
Jul 23, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jul 23, 2022

This removes the following deprecated items:

  • crossbeam-epoch:
    • CompareAndSetError
    • CompareAndSetOrdering
    • Atomic::compare_and_set
    • Atomic::compare_and_set_weak
  • crossbeam-utils:
    • AtomicCell::compare_and_swap

@taiki-e
Copy link
Member Author

taiki-e commented Jul 23, 2022

bors r+

This removes the following deprecated items:

- crossbeam-epoch:
  - `CompareAndSetError`
  - `CompareAndSetOrdering`
  - `Atomic::compare_and_set`
  - `Atomic::compare_and_set_weak`
- crossbeam-utils:
  - `AtomicCell::compare_and_swap`
@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Canceled.

@taiki-e
Copy link
Member Author

taiki-e commented Jul 23, 2022

bors r+

bors bot added a commit that referenced this pull request Jul 23, 2022
796: epoch: Remove ptr-to-int casts r=taiki-e a=taiki-e

Use [this hack](rust-lang/miri#1866 (comment)) to fix compatibility issues with Miri (see #490 (comment) for details). 

Due to the #545, still not compatible with stacked borrows. This will be fixed by the subsequent PR (#871).

Note: this is a breaking change because changes API of Pointable and Pointer traits

Fixes #579

881: Remove deprecated items r=taiki-e a=taiki-e

This removes the following deprecated items:

- crossbeam-epoch:
  - `CompareAndSetError`
  - `CompareAndSetOrdering`
  - `Atomic::compare_and_set`
  - `Atomic::compare_and_set_weak`
- crossbeam-utils:
  - `AtomicCell::compare_and_swap`

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Jul 23, 2022

Build succeeded:

@bors bors bot merged commit 568f558 into master Jul 23, 2022
@bors bors bot deleted the remove-deprecated branch July 23, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant