Skip to content

Commit

Permalink
update to node 10 lts. also some readme updates
Browse files Browse the repository at this point in the history
  • Loading branch information
williscool committed Oct 3, 2019
1 parent ab6bca9 commit 80918b9
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:9.1.0-stretch
FROM node:10.16.3-stretch

COPY .babelrc /dashboard/
COPY .editorconfig /dashboard/
Expand Down
20 changes: 16 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ You need install node using something like [nvm](https://github.com/creationix/n
also need to install npm
# Choose a version of node 4.0.0 or higher e.g.:
```
nvm use 9.1.0
nvm use 10.16.3
```
## Build Setup

Expand All @@ -20,12 +20,25 @@ npm install
Set the environment var API_URL. (use .env or set manually).

Use an .env
1. Create .env with `export API_URL=http://<API_SERVER>:<API_PORT>/api"`
1. Create .env with the example below
1. Load .env with `. .env`

Create config/dev.env.js and config/prod.env.js by running
```
.env

```
export API_URL="http://dev.vulk.co:4003/api"
export PORT=8080
#export TEST_URL="http://<YOUR_TEST_SERVER>"
```





./bin/create_env_js

```
# serve with hot reload at localhost:8080
Expand Down Expand Up @@ -58,7 +71,7 @@ docker build -t $DOCKER_IMAGE .

Then use docker
```
docker run -p $PORT:$PORT -e API_URL=$API_URL -e PORT=$PORT -ti cncf-ci-dashboard
docker run -p $PORT:$PORT -e API_URL=$API_URL -e PORT=$PORT -ti $DOCKER_IMAGE
```

or docker-compose
Expand Down Expand Up @@ -122,7 +135,6 @@ bundle install
bundle exec cucumber
```

---

TEST
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"scripts": {
"dev": "node build/dev-server.js",
"start": "node build/dev-server.js",
"start": "npm run dev",
"build": "node build/build.js",
"unit": "cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run",
"e2e": "node test/e2e/runner.js",
Expand Down

0 comments on commit 80918b9

Please sign in to comment.