Update RedPacket.java #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改随机红包产生规则
|
请描述下调整的原因。 |
|
通过debug发现，发现(int) (Math.random() * (maxMoney - minMoney) + minMoney)这段代码，在minMoney为19999的时候，由于maxMoney等于200*100，那么这段代码的结果恒为19999，所以带入参数(40000，2)的情况下导致剩余的那个红包一直等于20001 |
补齐变量定义
crossoverJie
reviewed
Dec 1, 2018
| @@ -40,16 +40,16 @@ | |||
| * 最大的红包是平均值的 TIMES 倍，防止某一次分配红包较大 | |||
| */ | |||
| private static final double TIMES = 2.1F; | |||
|
|
|||
| //变量定义 | |||
| if (MAX_MONEY * count <= money) { | ||
| System.err.println("请调大最小红包金额 MAX_MONEY=[" + MAX_MONEY + "]"); | ||
| return moneys ; | ||
| //金额检查，如果最大红包 * 个数 < 总金额或最小红包 * 个数 > 总金额；则需要调整红包总金额 |
There was a problem hiding this comment.
这里没必要抛异常了，像以前直接打印也没问题。不然所有的单测都需要改。
Repository owner
deleted a comment from
yjw0513
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改随机红包产生规则