Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade crossplane-runtime and implement new metrics #17

Merged

Conversation

smcavallo
Copy link
Collaborator

Signed-off-by: smcavallo smcavallo@hotmail.com

Description of your changes

Consume crossplane/crossplane-runtime#683 and crossplane/upjet#390.

Implements new metrics. Ex.

# HELP crossplane_managed_resource_exists The number of managed resources that exist
# TYPE crossplane_managed_resource_exists gauge
crossplane_managed_resource_exists{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Channel"} 0
crossplane_managed_resource_exists{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Destination"} 0
crossplane_managed_resource_exists{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Policy"} 0
crossplane_managed_resource_exists{gvk="dashboard.newrelic.upbound.io/v1alpha1, Kind=Dashboard"} 0
crossplane_managed_resource_exists{gvk="dashboard.newrelic.upbound.io/v1alpha1, Kind=DashboardJSON"} 0
crossplane_managed_resource_exists{gvk="log.newrelic.upbound.io/v1alpha1, Kind=ParsingRule"} 0
crossplane_managed_resource_exists{gvk="nrql.newrelic.upbound.io/v1alpha1, Kind=AlertCondition"} 0
crossplane_managed_resource_exists{gvk="nrql.newrelic.upbound.io/v1alpha1, Kind=DropRule"} 0
crossplane_managed_resource_exists{gvk="workflow.newrelic.upbound.io/v1alpha1, Kind=Workflow"} 0
# HELP crossplane_managed_resource_ready The number of managed resources in Ready=True state
# TYPE crossplane_managed_resource_ready gauge
crossplane_managed_resource_ready{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Channel"} 0
crossplane_managed_resource_ready{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Destination"} 0
crossplane_managed_resource_ready{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Policy"} 0
crossplane_managed_resource_ready{gvk="dashboard.newrelic.upbound.io/v1alpha1, Kind=Dashboard"} 0
crossplane_managed_resource_ready{gvk="dashboard.newrelic.upbound.io/v1alpha1, Kind=DashboardJSON"} 0
crossplane_managed_resource_ready{gvk="log.newrelic.upbound.io/v1alpha1, Kind=ParsingRule"} 0
crossplane_managed_resource_ready{gvk="nrql.newrelic.upbound.io/v1alpha1, Kind=AlertCondition"} 0
crossplane_managed_resource_ready{gvk="nrql.newrelic.upbound.io/v1alpha1, Kind=DropRule"} 0
crossplane_managed_resource_ready{gvk="workflow.newrelic.upbound.io/v1alpha1, Kind=Workflow"} 0
# HELP crossplane_managed_resource_synced The number of managed resources in Synced=True state
# TYPE crossplane_managed_resource_synced gauge
crossplane_managed_resource_synced{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Channel"} 0
crossplane_managed_resource_synced{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Destination"} 0
crossplane_managed_resource_synced{gvk="alert.newrelic.upbound.io/v1alpha1, Kind=Policy"} 0
crossplane_managed_resource_synced{gvk="dashboard.newrelic.upbound.io/v1alpha1, Kind=Dashboard"} 0
crossplane_managed_resource_synced{gvk="dashboard.newrelic.upbound.io/v1alpha1, Kind=DashboardJSON"} 0
crossplane_managed_resource_synced{gvk="log.newrelic.upbound.io/v1alpha1, Kind=ParsingRule"} 0
crossplane_managed_resource_synced{gvk="nrql.newrelic.upbound.io/v1alpha1, Kind=AlertCondition"} 0
crossplane_managed_resource_synced{gvk="nrql.newrelic.upbound.io/v1alpha1, Kind=DropRule"} 0
crossplane_managed_resource_synced{gvk="workflow.newrelic.upbound.io/v1alpha1, Kind=Workflow"} 0

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: smcavallo <smcavallo@hotmail.com>
@smcavallo smcavallo force-pushed the crossplane-runtime_v1.16.0 branch from 25409bc to c155c37 Compare May 17, 2024 16:47
@smcavallo smcavallo merged commit 402cb34 into crossplane-contrib:main May 17, 2024
7 checks passed
@smcavallo smcavallo deleted the crossplane-runtime_v1.16.0 branch May 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant