Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource notation example in Readme #22

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix resource notation example in Readme #22

merged 1 commit into from
Nov 13, 2023

Conversation

jan-di
Copy link
Contributor

@jan-di jan-di commented Nov 10, 2023

Fix issue in Readme. The Example shows an invalid structure.

@ezgidemirel
Copy link
Collaborator

Hi @jan-di, thanks for the PR! Can you please sign your commit with git commit -s to make DCO check pass?

@jan-di
Fix resource notation example in Readme
8fad14e 
Signed-off-by: Jan Dittrich <jan.dittrich@cgm.com>
@jan-di
Copy link
Contributor Author

jan-di commented Nov 13, 2023

@ezgidemirel done :)

ezgidemirel
ezgidemirel approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jan-di, LGTM!

@ezgidemirel ezgidemirel merged commit 6e96f14 into crossplane-contrib:main Nov 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezgidemirel ezgidemirel ezgidemirel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-di @ezgidemirel