Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make reviewable" hit "unsupported go version" issue #70

Open
zzxwill opened this issue Apr 23, 2021 · 4 comments · May be fixed by #72
Open

"make reviewable" hit "unsupported go version" issue #70

zzxwill opened this issue Apr 23, 2021 · 4 comments · May be fixed by #72
Labels
bug Something isn't working

Comments

@zzxwill
Copy link
Collaborator

zzxwill commented Apr 23, 2021

What happened?

When executing make reviewable, an issue happended.

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/crossplane/provider-alibaba git:(master) make reviewable
13:41:56 [ .. ] go generate darwin_amd64
13:42:03 [ OK ] go generate darwin_amd64
13:42:03 [ .. ] cleaning generated CRDs
13:42:04 [ OK ] cleaned generated CRDs
13:42:04 [ .. ] verify dependencies have expected content
all modules verified
13:42:08 [ OK ] go modules dependencies verified
13:42:08 [FAIL] unsupported go version. Please make install one of the following supported version: 1.7|1.8|1.9|1.10|1.11|1.12|1.13|1.14
make[1]: *** [go.init] Error 1
make: *** [lint] Error 2

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/crossplane/provider-alibaba git:(master) go version
go version go1.14.9 darwin/amd64

The go version meets 1.14.

How can we reproduce it?

  • Clone the project
  • Run make reviewable

What environment did it happen in?

Crossplane version:
NA

  • Cloud provider or hardware configuration
    Alibaba Cloud
  • Kubernetes version (use kubectl version)
    NA
  • Kubernetes distribution (e.g. Tectonic, GKE, OpenShift)
    NA
  • OS (e.g. from /etc/os-release)
    macOS 11.2.3 (20D91)
  • Kernel (e.g. uname -a)
    Darwin zhouzhengxi-macbook-pro-2020.local 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64
@zzxwill zzxwill added the bug Something isn't working label Apr 23, 2021
@muvaf
Copy link
Member

muvaf commented Apr 27, 2021

Bumping build submodule to latest should fix this, see upbound/build#140 for details.

zzxwill added a commit to zzxwill/provider-alibaba that referenced this issue Apr 27, 2021
@zzxwill
Bump build version to its latest
ce6272f 
By bumping the version of build submodule, it can fix
the issue of `make reviewable`.

Fix crossplane-contrib#70

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
@zzxwill zzxwill linked a pull request Apr 27, 2021 that will close this issue
Open
2 tasks
@zzxwill
Copy link
Collaborator Author

zzxwill commented Apr 27, 2021

@muvaf I made a PR in #72, but test CI failed. It's successful in my local run. Could you please help retry the CI? Thanks.

@muvaf
Copy link
Member

muvaf commented Apr 28, 2021

The error is related to this line. At some point, kind started not accepting capitals in cluster name so we changed INTTESTS to inttests in all providers.

@zzxwill
Copy link
Collaborator Author

zzxwill commented Jul 7, 2021

@muvaf I have fixed most issues you figured out. Now it failed when make check-diff in PR #72. I could not figure out why without any more detailed information and it worked in my local development environment. Could you please help take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump build version to its latest zzxwill/provider-alibaba
2 participants
@zzxwill @muvaf