Remove bad package name "util" #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zzxwill
force-pushed
the
bad-package-name
branch
from
9c4784f
to
26e8d89
Compare
zzxwill
force-pushed
the
bad-package-name
branch
from
26e8d89
to
951de73
Compare
zzxwill
force-pushed
the
bad-package-name
branch
from
951de73
to
aa3e2f2
Compare
Address Nic's comments: FWIW packages named util are considered an anti-pattern. See "bad package names" at https://blog.golang.org/package-names Signed-off-by: zzxwill <zzxwill@gmail.com>
zzxwill
force-pushed
the
bad-package-name
branch
from
aa3e2f2
to
a57bf80
Compare
|
Trigger the build without code change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Address Nic's comments: FWIW packages named util are considered an
anti-pattern. See "bad package names" at https://blog.golang.org/package-names
Fixes #95 (comment)
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Pending...