Support the use of EC2 spot instances as worker nodes

[cmdallas]

What problem are you facing?

The current worker node spec does not support the use of spot instances.

How could Crossplane help solve your problem?

Expose support for the use of EC2 spot fleets as worker nodes.

[negz]

Thanks for the feature request @cmdallas! One potential snag here is that we plan to move away from using CloudFormation under the hood in favour of managed node groups as part of #137. It seems like managed node groups don't currently support spot instances per aws/containers-roadmap#583.

[muvaf]

FWIW, it seems like AWS team is currently working on this feature, you can see the issue in We're working on it column here https://github.com/aws/containers-roadmap/projects/1

We'll likely begin the upgrade of EKS to v1beta1 quality very soon but my gut says we'll complete it before the spot instance support. Though it should be pretty straight-forward to add the spot instance support after v1beta1 once AWS supports it.

[muvaf]

We have v1beta1 level support for EKS but it seems AWS still hasn't implemented support for spot instances in the official API aws/containers-roadmap#583

[bdols]

Sounds like AWS added spot support in aws/containers-roadmap#583

[muvaf]

Seems like no API changes were required, so we should get this support without any code change. It'd be great if someone can test this so that we can close the issue.

[ytsarev]

@muvaf can't find a way to provide SPOT capacity type similar to https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_node_group#capacity_type

Looks like there is not matching field in https://doc.crds.dev/github.com/crossplane/provider-aws/eks.aws.crossplane.io/NodeGroup/v1alpha1@v0.17.0 .

Am I missing something?

[muvaf]

@ytsarev I think you're right, seems we don't have capacityType. Though in order to add it, we need to bump the AWS SDK v2 version.

[ayushghosh]

Any plans to implement this?

[haarchri]

@muvaf can we Close this Issue ? Because we merged #858