Fix Status.AtProvider not being updated on elbv2 types #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with the code generator not being able to find the applicable fields in Status.AtProvider and therefore not correctly generating the code to apply the status to the finalized CRD. Signed-off-by: EdgeJ <5093048+EdgeJ@users.noreply.github.com>
Signed-off-by: EdgeJ <5093048+EdgeJ@users.noreply.github.com>
Signed-off-by: EdgeJ <5093048+EdgeJ@users.noreply.github.com>
haarchri
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The
Status.AtProviderfields were not being correctly updated, mostly due to inconsistencies with the way theCreate*operations work. All Create options for elbv2 types return a slice of types. Without adding options to specify the output path needed, the code generator sets up the status object as an array of sdk types. Since these types don't map to any of the describe types, the generator skips adding logic to copy them into theatProviderfield. The changes here are mainly just adding options to the code generator config to force the generation to do the right thing.Fixes #1309
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Example yaml configurations were applied and verified that status fields are being filled in.
[contribution process]: https://git.io/fj2m9