Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks/cluster): outpost status fields optional #1576

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Nov 16, 2022

Description of your changes

1.6686110160807893e+09 ERROR controller.managed/cluster.eks.aws.crossplane.io Reconciler error {"reconciler group": "eks.aws.crossplane.io", "reconciler kind": "Cluster", "name": "baum-dev-cluster-76fz7", "namespace": "", "error": "cannot update managed resource status: Cluster.eks.aws.crossplane.io "baum-dev-cluster-76fz7" is invalid: status.atProvider.outpostConfig.outpostArns: Required value"}

This change fixes the above error, which resulted in no status of the resource being delivered.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually with the example

Signed-off-by: Charel Baum <charel.baum@accenture.com>
@wotolom
Copy link
Contributor Author

wotolom commented Nov 16, 2022

@haarchri @MisterMX I think, it would be good, to get this fix into v0.34.0.

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@haarchri haarchri merged commit 5c6c9f0 into crossplane-contrib:master Nov 16, 2022
@wotolom wotolom deleted the eks-outpost-fix branch August 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants