resourcerecordset: Should set AliasTarget when check if it is up to date #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting `AliasTarget` in `v1alpha1.ResourceRecordSetParameters`, `IsUpToDate()` will always return false since it do not fill up the field `AliasTarget` then `CreatePatch` will contains the part about `AliasTarget` when compare the the expect state. This will make it always try to do a useless update after observing the state. Signed-off-by: Jiahao Huang <july2993@gmail.com>
|
@haarchri |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When setting
AliasTargetinv1alpha1.ResourceRecordSetParameters,IsUpToDate()will always return false since it does not fill up the fieldAliasTargetthenCreatePatchwill contain the part aboutAliasTargetwhen comparing with the expected state.This will make it always try to do a useless update after observing the state.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Add unit test.
Note before fixing it, the first call of
IsUpToDatein the added test case should be true, but it return false.