Fix(replicationgroup): Wrong engine version format #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilde
force-pushed
the
fix/replication-group-engine-version
branch
7 times, most recently
from
7404a2b
to
4708afc
Compare
fix: engine version change on update Signed-off-by: Domene Esteban, Nil <nildomenee@gmail.com>
nilde
force-pushed
the
fix/replication-group-engine-version
branch
from
4708afc
to
63d4e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes a bug related to the engine version when trying to update a ReplicationGroup. When creating a ReplicationGroup and attempting to update any property, an error is raised. This error is caused by an incorrect format in the engine version parameter sent to AWS.
Explanation:
When you create a new ReplicationGroup, you will do it with the following format:
Engine version: X.X
When the resource is created, the engineVersion will be updated to:
Engine version X.X.X
And if you try to update the generated resource, it will raise an error caused by the engine version format that is now defined in the resource.
This change enforces always updating with the desired engineVersion format X.X
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
managed_test.goupdated in the PR to test the proposed change by attempting to update the resource with the wrong format and also tested against AWS.