Use new policy checker for iam.roles #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-melentyev
force-pushed
the
role-policy
branch
3 times, most recently
from
19c6ac6
to
4ecfa0d
Compare
To not trigger update event and update role in AWS when AWS changes formatting in policy document. Signed-off-by: Max Melentyev <max.melentyev@reddit.com>
MisterMX
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not trigger update event and update role in AWS when AWS changes formatting in policy document.
Description of your changes
Policy checker in
pkg/utils/policy/oldconsiders that policies are different if one of them has"Action": "x"and another one has"Action": ["x"]. This PR fixes it.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested