Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda/function): resource is ready when function is inactive due to idle #2084

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Jul 29, 2024

Description of your changes

for Function.lambda:

with previous/current behavior the resource is set to Ready: False when idle
The previous/current handling differs from the way Upbound Function.lambda behaves. This change aims to adapt this.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

… to idle

Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <charel.baum-extern@deutschebahn.com>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

@MisterMX MisterMX merged commit dbe8d46 into crossplane-contrib:master Jul 29, 2024
9 checks passed
Copy link

Successfully created backport PR #2085 for release-0.49.

@wotolom wotolom deleted the lmbda-function-special-handle-inactive-idle-state branch July 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants