Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Bump crossplane-runtime to v0.14.1 #824

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

negz
Copy link
Member

@negz negz commented Sep 8, 2021

Description of your changes

This PR fixes #802 for the v0.18 release. See https://github.com/crossplane/crossplane-runtime/releases/tag/v0.14.1 and crossplane/crossplane-runtime#283 for more detail.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I tested this change extensively as part of crossplane/crossplane-runtime#283. I've run a cursory version of the same test on this specific PR (i.e. spun a composition of EC2 resources up and down once).

This means we'll wait three minutes from the time a resource was most recently
created before we trust the EC2 API if/when it indicates the resource doesn't
exist.

Signed-off-by: Nic Cope <negz@rk0n.org>
2c73c90

I'm blindly copying this from the above commit. It's the only difference I can
find between master (where e2e tests pass) and release-0.18 (where they don't).

Signed-off-by: Nic Cope <negz@rk0n.org>
@negz negz requested a review from chlunde September 8, 2021 06:02
@negz negz merged commit 885129f into crossplane-contrib:release-0.19 Sep 8, 2021
@negz negz deleted the release-0.19-rt-0.14.1 branch September 8, 2021 06:03
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
Add warning for monolithic provider to the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants