Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Registry support #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaspahomov
Copy link

Description of your changes

Add Registry support.

I've placed Registry in compute api, but I can move Registry in another version.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Unit tests
  • Manually tested

Signed-off-by: vaspahomov <vas2142553@gmail.com>
@ulucinar
Copy link
Collaborator

Hi @vaspahomov,
Could you please take a look at my review comments on the more recent #264, #269 and #279 and if needed, address common issues for this PR. Would that make sense? Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants