Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of NetworkEndpointGroup #347

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raffaelespazzoli
Copy link

@raffaelespazzoli raffaelespazzoli commented Jul 23, 2021

Signed-off-by: raffaelespazzoli raffaele.spazzoli@gmail.com

Description of your changes

This is a WIP

Adds NetworkEndpointGroup API

I have:

  • [x ] Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

some unit tests have been created

Signed-off-by: raffaelespazzoli <raffaele.spazzoli@gmail.com>
@raffaelespazzoli raffaelespazzoli marked this pull request as draft July 23, 2021 08:44
@raffaelespazzoli
Copy link
Author

I create this PR to have a place where to discuss an issue I'm having (I will likely have more since this is my first contribution).
I'm getting a golint failure due to high cyclomatic complexity. The code looks good to me and I don't know how to simplify it, so I'm looking for some advice on how to pass this issue. The high cyclomatic score seems to be triggered by a nested if, which is the right thing to do n that context as a switch cannot be used. The Update function in networkendpointgroup.go is where the issue occurs.

@negz negz changed the title first draft First draft of NetworkEndpointGroup Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant