Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade crossplane-runtime dependency #465

Conversation

Feggah
Copy link
Collaborator

@Feggah Feggah commented Sep 30, 2022

Description of your changes

  • Upgrade crossplane-runtime dependency version to latest

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Using the latest crossplane-runtime feature, which is the paused annotation, I created the following managed resource:

apiVersion: database.gcp.crossplane.io/v1beta1
kind: CloudSQLInstance
metadata:
  name: example-cloudsql-instance
spec:
  forProvider:
    databaseVersion: POSTGRES_11
    region: us-west2
    settings:
      tier: db-custom-1-3840
      dataDiskSizeGb: 20
  providerConfigRef:
    name: example
  writeConnectionSecretToRef:
    name: example-cloudsql-connection-details
    namespace: crossplane-system

and then adding the annotation[crossplane.io/paused] with "true" value, the paused Event was created:

  Normal   ReconciliationPaused             2s (x2 over 2s)   managed/cloudsqlinstance.database.gcp.crossplane.io  Reconciliation is paused via the pause annotation

And the conditions were also updated:

Status:
  At Provider:
  Conditions:
    Last Transition Time:  2022-09-30T17:38:56Z
    Reason:                ReconcilePaused
    Status:                False
    Type:                  Synced

Signed-off-by: Feggah <gabidferreira9@gmail.com>
Signed-off-by: Feggah <gabidferreira9@gmail.com>
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Feggah !

@Feggah Feggah merged commit 30ff589 into crossplane-contrib:master Oct 1, 2022
@Feggah Feggah deleted the patch/upgrade-crossplane-runtime-version branch October 1, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants