Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle pending deletion of projects and migrate to official gitlab golang client #179

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

BigGold1310
Copy link
Contributor

Description of your changes

  • Migrates the golang client to the official gitlab one
  • Adds the ability to ignore pending deletions of projects or to delete projects immediately.

I've integrated the changes from #174 done by @mattenklicker as I had to update the gitlab client dependency introducing the new fields.

Fixes #149
Fixes #172
Obsoletes #174

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Unit testing
  • Generic test by a user requiring the immediate deletion appreciated

Signed-off-by: Atman Sense <atman.sense@accenture.com>
Signed-off-by: Cyrill Näf <cyrill.naef@gmail.com>
Co-authored-by: Atman Sense <atman.sense@accenture.com>
Signed-off-by: Cyrill Näf <cyrill.naef@gmail.com>
Copy link
Collaborator

@dariozachow dariozachow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@dariozachow dariozachow merged commit cd3b51d into crossplane-contrib:master Feb 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move to gitlab.com/gitlab-org/api/client-go Pending deletion on gitlab
2 participants