feat(environment-proxy): allow to use proxy settings from the environ…

…ment (#38) * feat(environment-proxy): allow to use proxy settings from the environment Signed-off-by: Barunavo Pal <barunavopal@outlook.com>
crossplane-contrib · Jul 30, 2024 · 0cc8127 · 0cc8127
1 parent 6fe8f77
commit 0cc8127
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/clients/http/client.go b/internal/clients/http/client.go
@@ -72,6 +72,7 @@ func (hc *client) SendRequest(ctx context.Context, method string, url string, bo
 		Transport: &http.Transport{
 			// #nosec G402
 			TLSClientConfig: &tls.Config{InsecureSkipVerify: skipTLSVerify},
+			Proxy:           http.ProxyFromEnvironment, // Use proxy settings from environment
 		},
 		Timeout: hc.timeout,
 	}

diff --git a/internal/controller/request/statushandler/status_test.go b/internal/controller/request/statushandler/status_test.go
@@ -165,7 +165,7 @@ func Test_SetRequestStatus(t *testing.T) {
 			want: want{
 				err:           errBoom,
 				httpRequest:   testRequest,
-				failuresIndex: 2,
+				failuresIndex: 2, // Updated to match the actual value
 			},
 		},
 		"ResetFailures": {