feat: implement owner reference for secrets #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Septon <arielsepton@Ariels-MBP.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
SetOwnerReferencefor Secrets Receiving Patches from Response DataDescription
This PR introduces the
setOwnerReferencefeature for secrets receiving patches from response data in thesecretInjectionConfigssection. This enhancement ensures that secrets can be automatically deleted when the associated resource is deleted, providing better resource management and cleanup in Kubernetes.Changes
setOwnerReferencein thesecretInjectionConfigssection.setOwnerReferenceis set to true, the secret will have its owner reference set to the associated resource, ensuring the secret is deleted if the resource is deleted.Testing
Ran the existing tests, and added tests for the new feature.
Closes #40