Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: promote to upbound marketplace #159

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

Duologic
Copy link
Member

Fixes the CI job to promote this provider to the marketplace.

Signed-off-by: Duologic <jeroen@simplistic.be>
Copy link
Collaborator

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how this works right now --- there's this

provider-sql/Makefile

Lines 54 to 56 in 61a1672

# NOTE(hasheddan): skip promoting on xpkg.upbound.io as channel tags are
# inferred.
XPKG_REG_ORGS_NO_PROMOTE ?= xpkg.upbound.io/crossplane-contrib

Just wondering if that matters, mainly being new to this pipeline and not knowing anything about publishing to the marketplace. 🙃

@Duologic
Copy link
Member Author

cc/ @hasheddan Can you enlighten us?

@jastang
Copy link
Contributor

jastang commented Jan 5, 2024

I don't really understand how this works right now --- there's this

provider-sql/Makefile

Lines 54 to 56 in 61a1672

# NOTE(hasheddan): skip promoting on xpkg.upbound.io as channel tags are
# inferred.
XPKG_REG_ORGS_NO_PROMOTE ?= xpkg.upbound.io/crossplane-contrib

Just wondering if that matters, mainly being new to this pipeline and not knowing anything about publishing to the marketplace. 🙃

hey there @iainlane -- this isn't required to publish to the Upbound marketplace. this repo is already configured to do so when CI is run on specific branches (see: https://github.com/upbound/build/blob/master/makelib/xpkg.mk#L119-L123)

I see a few tags have already been pushed to the repository: https://explore.ggcr.dev/?repo=xpkg.upbound.io%2Fcrossplane-contrib%2Fprovider-sql. To have a package be indexed into a Marketplace listing, they will need to have an explicit release tag, e.g. v0.7.0.

@Duologic Duologic merged commit afdf580 into master Jan 24, 2024
7 checks passed
@danielloader
Copy link

Thanks for the work here - how long do you think it'll take before the marketplace lists this provider?

@fgaillot-qosenergy
Copy link
Contributor

Hello,

I would like to test the new v0.9.0 version but image is not available on the Upbound marketplace. Would it be possible to publish this image ? I guess it would also make the marketplace lists this provider on their UI.

Thanks

@haarchri
Copy link
Member

haarchri commented Feb 3, 2024

@fgaillot-qosenergy it's now available via: xpkg.upbound.io/crossplane-contrib/provider-sql:v0.9.0 - started the public listing in Upbound Marketplace - will be happen latest next week

@haarchri
Copy link
Member

haarchri commented Feb 7, 2024

mariusziemke pushed a commit to edudip/provider-sql that referenced this pull request Jun 10, 2024
Signed-off-by: Duologic <jeroen@simplistic.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants