PostgreSQL CREATE SCHEMA support #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged #182 |
This adds support for CREATE SCHEMA (not any DDL like Schema hero). This is needed to run third party solutions that require the schema to exist, like grafana operator and temporal operator. Co-authored-by: Lars Haugan <456305+larhauga@users.noreply.github.com> Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
…er info Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
chlunde
force-pushed
the
postgresql-schema
branch
from
418bd77
to
6371f88
Compare
|
@Duologic rebased |
Duologic
approved these changes
Jun 10, 2024
mariusziemke
pushed a commit
to edudip/provider-sql
that referenced
this pull request
Jun 10, 2024
* Schema controller for PostgreSQL This adds support for CREATE SCHEMA (not any DDL like Schema hero). This is needed to run third party solutions that require the schema to exist, like grafana operator and temporal operator. Co-authored-by: Lars Haugan <456305+larhauga@users.noreply.github.com> Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Generate files for PostgreSQL Schema Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Expand PostgreSQL config example to include secret and ssl mode, docker info Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> * Avoid new(string) and use nicer ptr.To values in test Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> --------- Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no> Co-authored-by: Lars Haugan <456305+larhauga@users.noreply.github.com>
|
Hello, can a new release be created, as this is already merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates #51 - but this does not solve the same issue. I think that talks about any DDL, this change talks specifically about SQL SCHEMA. I think the other idea should use a different CRD than Schema, rather than changing this :)
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested