Provider-SQL reduce statement and connection overhead #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Postgres and added condition to only execute CONNECTION LIMIT changes when there is an actual change.
…y and adjusted the spec of the crd to align with other parts of the provider.
…ting and variable naming
…ting and variable naming
…ting and variable naming
ajcaldera1
changed the title
ajcaldera1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #194
Fixes #195
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Local unit tests verified.
Scenario 1: Role created with no connection limit Result: Success, no further statements setting CONNECTION LIMIT were noted in the postgres.log
Scenario 2: Role created with connection limit -1 Result: Success, no further statements setting CONNECTION LIMIT were noting in the postgres.log
Scenario 3: Role created with connection limit -1 and updated to connection limit 5 Result: Success, only 1 ALTER ROLE CONNECTION LIMIT statement was produced
Also noted reduced connection overhead with implementation of connection pooling.