Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mysql-grants by table #83

Merged
merged 4 commits into from
May 3, 2022

Conversation

kaessert
Copy link

@kaessert kaessert commented Apr 8, 2022

Description of your changes

Introduces support for grants by individual tables in mysql

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Code was tested in local-setup with kind-cluster created with make dev. A local mysql-instance was connected to the provider and manual verification has been done.
Unit-tests were part of standard-procedure.
I did not adjust e2e. I ran these but i think i'm missing something because it's failing with Error from server (BadRequest): container "provider-sql" in pod "provider-sql-provider-sql-ffb4544-6kv29" is waiting to start: ErrImageNeverPull

@Duologic
Copy link
Member

I did not adjust e2e. I ran these but i think i'm missing something because it's failing with Error from server (BadRequest): container "provider-sql" in pod "provider-sql-provider-sql-ffb4544-6kv29" is waiting to start: ErrImageNeverPull

I think you need to run make build before make e2e, perhaps make clean build if you want to be sure the latest changes are in there. CI will run it too, if it is green, no worries. ;)

Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note the failing CI lint job, we use golangci-lint v1.31 as we follow upstream build/repository, this might explain the failure.

@Duologic
Copy link
Member

I'm attempting to fix the lint CI job in #88

@kaessert
Copy link
Author

Thanks for your suggestion regarding e2e-tests. It's working fine now: 11:30:12 [ OK ] integration tests passed

@Duologic
Copy link
Member

I'm also fixing the e2e in #88, I noticed it was still running against Crossplane v0.14.0 🤭

@Duologic
Copy link
Member

#88 is merged, do you mind rebasing?

@kaessert
Copy link
Author

@Duologic omw :)

cite added 4 commits April 29, 2022 17:41
Signed-off-by: cite <cite@animals.atarax.me>
Signed-off-by: cite <cite@animals.atarax.me>
Signed-off-by: cite <cite@animals.atarax.me>
Signed-off-by: cite <cite@animals.atarax.me>
@Duologic Duologic merged commit 3fcd1c9 into crossplane-contrib:master May 3, 2022
@alexbowers
Copy link

@Duologic Any chance we can get a tag of the latest release with this in it?

@tkaesserfm
Copy link

@alexbowers crossplane/provider-sql:v0.4.1-17.g3fcd1c9 contains it :)

@dudicoco
Copy link

@atarax any plans on adding this for postgres as well?

@tkaesserfm
Copy link

tkaesserfm commented Oct 17, 2022

@dudicoco not currently :/ I could gladly offer some support in doing it but i have too much going on atm to implement it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants