-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mysql-grants by table #83
Conversation
I think you need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note the failing CI lint job, we use golangci-lint v1.31 as we follow upstream build/repository, this might explain the failure.
I'm attempting to fix the lint CI job in #88 |
Thanks for your suggestion regarding e2e-tests. It's working fine now: |
I'm also fixing the e2e in #88, I noticed it was still running against Crossplane v0.14.0 🤭 |
#88 is merged, do you mind rebasing? |
@Duologic omw :) |
Signed-off-by: cite <cite@animals.atarax.me>
Signed-off-by: cite <cite@animals.atarax.me>
Signed-off-by: cite <cite@animals.atarax.me>
Signed-off-by: cite <cite@animals.atarax.me>
@Duologic Any chance we can get a tag of the latest release with this in it? |
@alexbowers |
@atarax any plans on adding this for postgres as well? |
@dudicoco not currently :/ I could gladly offer some support in doing it but i have too much going on atm to implement it myself. |
Description of your changes
Introduces support for grants by individual tables in mysql
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Code was tested in local-setup with kind-cluster created with
make dev
. A local mysql-instance was connected to the provider and manual verification has been done.Unit-tests were part of standard-procedure.
I did not adjust e2e. I ran these but i think i'm missing something because it's failing with
Error from server (BadRequest): container "provider-sql" in pod "provider-sql-provider-sql-ffb4544-6kv29" is waiting to start: ErrImageNeverPull