-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin aws-sdk-go-v2 dependency versions for ClusterAuth presign breaking change #1251
Conversation
…g change Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Is it possible to add a test to catch a regression here in the future? |
ClusterAuth is already uptestable, and included in the We might consider utilizing https://github.com/upbound/configuration-aws-eks, some test MRs utilizing provider-kubernetes or some post-test script utilizing |
Hi @erhancagirici,
Could you please also trigger an uptest on |
…nfig Signed-off-by: Erhan Cagirici <erhan@upbound.io>
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @erhancagirici, lgtm.
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
Successfully created backport PR #1257 for |
It looks like this was probably caused by aws/aws-sdk-go-v2#2438. I see a bunch of other projects citing that PR as an issue too. I don't understand why yet. |
Description of your changes
Fixes #1248
Recent patch version bumps at the following
aws-sdk-go-v2
modules seems to break the request signature of the token for the generated kubeconfig forClusterAuth
resource.This change reverts the version bumps and pins the versions.
Adds a separate standalone example manifest for
ClusterAuth
resource and added an Uptest post-assert hook for testing the resulting kubeconfig, by executing simple kubectl commands to ensure the cluster authentication.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
ClusterAuth
MR example, that fails on 1.3.0