feat: aws_ec2_fleet resource

[teabot]

Description of your changes

Added aws_ec2_fleet resource to the provider.

Fixes #

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable to ensure this PR is ready for review.
• Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Local run of uptest:

> export UPTEST_EXAMPLE_LIST=examples/ec2/v1beta1/fleetrequest.yaml
> make e2e
...
=== CONT  kuttl
    harness.go:402: run tests finished
    harness.go:511: cleaning up
    harness.go:553: skipping cluster tear down
    harness.go:554: to connect to the cluster, run: export KUBECONFIG="/Users/elliot.west/git/provider-upjet-aws/kubeconfig"
--- PASS: kuttl (50.59s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (49.81s)
PASS
19:26:45 [ OK ] running automated tests

[jeanduplessis]

/test-examples="examples/ec2/v1beta1/fleetrequest.yaml"

[turkenf]

Thank you for your effort @teabot, I left a few comments for you to consider.

[teabot]

Thanks for the feedback @turkenf. I have applied the changes requested. Note that in this providers, the existing spot fleet nomeclature includes a Request suffix. That may also be considered to be erroneous, but I'll consider it outside of the scope of this ticket.

[jeanduplessis]

/test-examples="examples/ec2/v1beta1/fleetrequest.yaml"

[teabot]

/test-examples="examples/ec2/v1beta1/fleet.yaml"

[turkenf]

/test-examples="examples/ec2/v1beta1/fleet.yaml"

[teabot]

This example passes local upsets, however I notice the following issues, and would appreciate help solving them:

1. forProvider.launchTemplateConfig.launchTemplateSpecification.versionSelector does not function properly and returns null despite all launch templates having a version (ec2: Fleet missing reference to launch template version #118). Please advise where I might look to fix this. I bypass this by setting a value of (string)"1", when we might also reasonably expect this to be an integer. Note that this does't affect my use-case, and so I'd been keen for this PR to move forward regardless, however I would prefer to fix this.
2. In TF, --no-terminate-instances seems to be set by default to true for fleet type instant, which is not allowed. This is perhaps a TF issue, but if there is a way to manage this behaviour in this provider then please let me know.
3. Some properties, that we might know to accept only integers or booleans, require a string type. Presumably this is erroneously defined/resolved from TF and enforced in the CRD. If there is a way to correct this behaviour locally in this provider, please let me know.

cc. @turkenf

[turkenf]

/test-examples="examples/ec2/v1beta1/fleet.yaml"

[teabot]

@turkenf Is anything else required here?

[turkenf]

Thank you very much for your interest @teabot.

About the issues and solutions you noticed in this comment, let's open the issues and discuss them there. There is already an issue with missing reference, you can open issues for other ones. I think these issues are not a blocker for us to move this PR forward.

[turkenf]

And please run make generate before pushing https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10160095033/job/28212845109?pr=1405

[teabot]

And please run make generate before pushing https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10160095033/job/28212845109?pr=1405

Done

[turkenf]

/test-examples="examples/ec2/v1beta1/fleet.yaml"

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10283336838

[turkenf]

LGTM 🙌