Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description to consoleAccess field for MQ User #1453

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add description to consoleAccess field for MQ User #1453

merged 1 commit into from
Aug 8, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Aug 8, 2024 •
edited
Loading

Description of your changes

This PR adds description to consoleAccess field for MQ User.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

@turkenf
Add description to consoleAccess field for MQ User
863d372 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
mergenci
mergenci approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf. LGTM. There aren't any runtime changes in this PR, nevertheless we manually tested the changes together. It looks like MQ User is Uptestable.

@turkenf turkenf merged commit ad89d40 into crossplane-contrib:main Aug 8, 2024
11 checks passed
@turkenf turkenf deleted the add-desc-mquser branch August 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergenci mergenci mergenci approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@mbbush mbbush Awaiting requested review from mbbush mbbush is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turkenf @mergenci