Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure LBTrustStore resource and add example #1475

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Aug 27, 2024

Description of your changes

Configures LBTrustStore.elbv2 resource and add the example

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Via uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10586728565

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 27, 2024

/test-examples="examples/elbv2/v1beta1/lbtruststore.yaml"

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Aug 28, 2024

/test-examples="examples/elbv2/v1beta1/lbtruststore.yaml"

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf 🙏 LGTM.

@turkenf turkenf merged commit 9b615fd into crossplane-contrib:main Aug 29, 2024
12 checks passed
@turkenf turkenf deleted the add-trust-store branch August 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants