Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_account_region resource #1494

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Sep 18, 2024

Description of your changes

This PR adds the Region.account.aws.upbound.io/v1beta1 resource to enable or disable a particular region for an AWS account.

Fixes #1137

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually tested

  • After applying the YAML with regionName: ap-southeast-3 and enabled: true
Screenshot 2024-09-18 at 22 51 07
  • After the resource is successfully created:
status:
  atProvider:
    accountId: ""
    enabled: true
    id: ap-southeast-3
    optStatus: ENABLED
    regionName: ap-southeast-3
  conditions:
  - lastTransitionTime: "2024-09-18T19:46:01Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2024-09-18T19:57:37Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation
  - lastTransitionTime: "2024-09-18T19:57:38Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-09-18T20:02:03Z"
    reason: UpToDate
    status: "True"
    type: Test
Screenshot 2024-09-18 at 23 01 31
  • Removing the resource from the cluster means that the provider will stop managing of this region, which will have no effect. To disable the region, must be set enabled: false.
Screenshot 2024-09-18 at 23 34 21

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf marked this pull request as ready for review September 19, 2024 08:13
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf. LGTM.

@turkenf turkenf merged commit 4a84e6b into crossplane-contrib:main Sep 19, 2024
11 checks passed
@turkenf turkenf deleted the add-account-region branch September 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for resource or feature to support AWS Opt-In regions enable/disable
2 participants