nolint:gocyclo resource configurations
#1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
jeanduplessis
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
//nolint:gocycloto resource configuration files,config/*/config.go, that didn't have it.// nolint:gocyclo, replace it with//nolint:gocyclo, which seems to be the standard form going forward.//nolint:gocyclohas been our de facto solution to cyclomatic complexity errors in resource configuration files. Cyclomatic complexity doesn't really apply to resource configurations. Configurations contain limited business logic, if any, which is independent between resources, even if they are defined inside the same function.Our linter takes a long time to complete. Discovering the cyclomatic complexity error after a standard resource configuration introduces unnecessary latency to our release process. Here is the latest example: #1528
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
See the result of the linter job.