Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PathARNExtractor for kms_key_id to rds cluster #1533

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Oct 22, 2024

Description of your changes

Adds the PathARNExtractor for kms_key_id to the rds cluster resource

Fixes: #1523

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with uptest (https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11456655642) and manually:

  conditions:
  - lastTransitionTime: "2024-10-22T08:42:00Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2024-10-22T08:42:55Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-10-22T08:42:53Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation
  - lastTransitionTime: "2024-10-22T08:44:24Z"
    reason: UpToDate
    status: "True"
    type: Test

Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Oct 22, 2024

/test-examples="examples/rds/v1beta1/cluster-with-kmskey.yaml"

@turkenf turkenf marked this pull request as ready for review October 22, 2024 09:13
Copy link
Contributor

@erhancagirici erhancagirici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @turkenf, LGTM

@turkenf turkenf merged commit 8ef9eff into crossplane-contrib:main Oct 22, 2024
12 checks passed
@turkenf turkenf deleted the issue-1523 branch October 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Creating or importing rds-cluster with kms-key supplied by selector fails
2 participants