Move away from deprecated workflows #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanduplessis
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
jeanduplessis
force-pushed
the
cleanup_publish
branch
from
a4d3354 to
c6863f6
Compare
Signed-off-by: Jean du Plessis <jean@upbound.io>
jeanduplessis
force-pushed
the
cleanup_publish
branch
2 times, most recently
from
6e31edc to
bbe3c16
Compare
Signed-off-by: Jean du Plessis <jean@upbound.io>
jeanduplessis
force-pushed
the
cleanup_publish
branch
2 times, most recently
from
b070ec0 to
a3721f0
Compare
Signed-off-by: Jean du Plessis <jean@upbound.io>
jeanduplessis
force-pushed
the
cleanup_publish
branch
from
a3721f0 to
03a62f2
Compare
|
/test-examples="examples/iam/v1beta1/policy.yaml" |
Signed-off-by: Jean du Plessis <jean@upbound.io>
jeanduplessis
force-pushed
the
cleanup_publish
branch
from
ed8b1a4 to
b459ee9
Compare
|
/test-examples="examples/ec2/v1beta1/vpc.yaml" |
jeanduplessis
changed the title
jeanduplessis
changed the title
|
/test-examples="examples/glue/v1beta1/catalogdatabase.yaml" |
turkenf
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Thank you @jeanduplessis, I left a few small comments.
I updated the required checks from the branch protection rules with the new ones, and also triggered a test to test the uptest datasource.
We can also add a label to test the backport pipeline and check it after the PR merge.
Co-authored-by: Fatih Türken <103541666+turkenf@users.noreply.github.com>
Signed-off-by: Jean du Plessis <jean@upbound.io>
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.16
git worktree add -d .worktree/backport-1551-to-release-1.16 origin/release-1.16
cd .worktree/backport-1551-to-release-1.16
git switch --create backport-1551-to-release-1.16
git cherry-pick -x ad5da24cbd65531c50ae6caa1dfa16a32bf95be3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The workflows in the upbound/official-providers-ci are deprecated.
This PR moves the code into this repo.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Workflow runs on this PR.