Consume upjet ProviderScheduler #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/ec2/vpc.yaml" |
internal/clients/provider_config.go
Outdated
| @@ -51,6 +51,7 @@ const ( | |||
| errAWSConfigUpbound = "failed to get AWS config using Upbound identity" | |||
|
|
|||
| upboundProviderIdentityTokenFile = "/var/run/secrets/upbound.io/provider/token" | |||
| defaultIdentityTokenFile = "/var/run/secrets/eks.amazonaws.com/serviceaccount/token" | |||
There was a problem hiding this comment.
It seems that we do not use this constant. Could you please remove it?
There was a problem hiding this comment.
Done. Thanks for catching it.
|
Some test results that are done via this branch content: |
- Enables the shared server runtime - Adds --provider-ttl command-line option Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/ec2/vpc.yaml" |
sergenyalcin
approved these changes
Mar 27, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Associated with: #325
This PR reenables the shared gRPC server runtime previously disabled due to external resource leakage issues. It consumes the new provider scheduler from upjet and:
--provider-ttlcommand-line option through which the max TTL used by the shared scheduler can be configured.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This PR has been tested in the experiments done here:
#576