Add Private DNS Resolver Outbound Endpoint azurerm_private_dns_resolver_outbound_endpoint
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: faizan-younus <faizan@mobilabsolutions.com>
faizan-younus
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/network/v1beta1/privatednsresolveroutboundendpoint.yaml" |
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
…1.23 bump go version to 1.23
…ovate/go-github.com-golang-jwt-jwt-v4-vulnerability Update module github.com/golang-jwt/jwt/v4 to v4.5.1 [SECURITY]
turkenf
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Thank you @faizan-younus, I left a small comment about the license statement and it would be good if you can rebase your branch to main.
Also, could you please add the license statement that we missed in the PrivateDNSResolverInboundEndpoint resource?
| @@ -0,0 +1,99 @@ | |||
| apiVersion: network.azure.upbound.io/v1beta1 | |||
There was a problem hiding this comment.
Could you please add the license statement?
Suggested change
| apiVersion: network.azure.upbound.io/v1beta1 | |
| # SPDX-FileCopyrightText: 2024 The Crossplane Authors <https://crossplane.io> | |
| # | |
| # SPDX-License-Identifier: CC0-1.0 | |
| apiVersion: network.azure.upbound.io/v1beta1 |
Signed-off-by: faizan-younus <faizan@mobilabsolutions.com>
Signed-off-by: faizan-younus <faizan@mobilabsolutions.com>
…om:faizan-younus/provider-upjet-azure into feature/privatednsresolveroutboundendpoint Signed-off-by: faizan-younus <faizan@mobilabsolutions.com>
|
/test-examples="examples/network/v1beta1/privatednsresolveroutboundendpoint.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added the resource
azurerm_private_dns_resolver_outbound_endpointwhich is already available in the terraform registry.Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
The code was tested locally with a KIND cluster and by running
Results