Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump upjet and add new examples with secret for container app resource #873

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Bump upjet and add new examples with secret for container app resource #873

merged 4 commits into from
Nov 20, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Nov 11, 2024 •
edited
Loading

Description of your changes

This PR bumps upjet to the commit be5e03679440 for the fix about getting sensitive parameters and adds new examples for container app resource.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 11, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 11, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 11, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@erhancagirici erhancagirici mentioned this pull request Nov 12, 2024
Merged
3 tasks
@turkenf turkenf force-pushed the z-issue-700 branch 2 times, most recently from 30f0e56 to 885cb8a Compare November 12, 2024 17:24
@turkenf
Copy link
Collaborator Author

turkenf commented Nov 12, 2024

/test-examples="examples/containerapp/v1beta2/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 12, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 12, 2024

/test-examples="examples/containerapp/v1beta2/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 12, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 13, 2024

/test-examples="examples/containerapp/v1beta2/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 13, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf
Bump upjet to the commit be5e03679440
be7fb20 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Add container app example with secret
7ae502c 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/containerapp/v1beta2/containerapp-with-secret.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf turkenf changed the title Remove sensitive conf for container app resource and add a new example with secret Bump upjet and add new examples with secret for container app resource Nov 18, 2024
@turkenf turkenf marked this pull request as ready for review November 18, 2024 10:40
@turkenf
Backport api changes from v1beta2 to v1beta1
31f0780 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/storage/v1beta1/account.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/alertsmanagement/v1beta1/monitoractionruleactiongroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/consumption/v1beta1/budgetresourcegroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/containerapp/v1beta1/containerapp.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/consumption/v1beta1/budgetresourcegroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 18, 2024

/test-examples="examples/consumption/v1beta1/budgetresourcegroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Nov 19, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

@turkenf
Run make generate
215b8d9 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Nov 20, 2024

/test-examples="examples/containerapp/v1beta1/containerapp-with-secret.yaml"

erhancagirici
erhancagirici approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@erhancagirici erhancagirici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @turkenf

@turkenf turkenf merged commit 1c27470 into crossplane-contrib:main Nov 20, 2024
9 checks passed
@turkenf turkenf deleted the z-issue-700 branch November 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erhancagirici erhancagirici erhancagirici approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turkenf @erhancagirici