Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crossplane-runtime version to consume the fix of MR metrics #132

Merged

Conversation

sergenyalcin
Copy link
Collaborator

@sergenyalcin sergenyalcin commented May 15, 2024

Description of your changes

This PR bumps crossplane-runtime version to consume the fix of MR metrics. Please see the reference PR: crossplane/crossplane-runtime#688

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Via uptest: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9094237569

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin force-pushed the bump-crossplane-runtime branch from 1ec5f11 to 54b8f0a Compare May 15, 2024 09:54
@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/applications/application.yaml"

@sergenyalcin
Copy link
Collaborator Author

/test-examples="examples/applications/v1beta2/application.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin, lgtm.

@sergenyalcin
Copy link
Collaborator Author

https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9093648537 was failed because of the wrong comment. I re-trigger with a correct one and it passed. The successful job is in the PR description.

@sergenyalcin sergenyalcin merged commit e736752 into crossplane-contrib:main May 16, 2024
10 of 11 checks passed
@sergenyalcin sergenyalcin deleted the bump-crossplane-runtime branch May 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants