Adding google_bigtable_app_profile, google_bigtable_gc_policy, google_bigtable_instance, google_bigtable_instance_iam_binding, google_bigtable_instance_iam_member, google_bigtable_instance_iam_policy, google_bigtable_table, google_bigtable_table_iam_binding, google_bigtable_table_iam_member, google_bigtable_table_iam_policy resources to v1beta1 version #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/bigtable/appprofile.yaml" |
mykolalosev
force-pushed
the
issue-94
branch
2 times, most recently
from
25ae345 to
ba3a93a
Compare
|
/test-examples="examples/bigtable/appprofile.yaml" |
|
/test-examples="examples/bigtable/appprofile.yaml" |
|
/test-examples="examples/bigtable/garbagecollectionpolicy.yaml" |
|
/test-examples="examples/bigtable/instance.yaml" |
|
/test-examples="examples/bigtable/table.yaml" |
sergenyalcin
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding 10 resources to v1beta1 version:
Fixes #94
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manual:
google_bigtable_instance_iam_policy - The resource requires a real Project ID
google_bigtable_table_iam_policy - The resource requires a real Project ID
Manual & Uptest:
google_bigtable_app_profile - https://github.com/upbound/provider-gcp/actions/runs/3930850700
google_bigtable_gc_policy - https://github.com/upbound/provider-gcp/actions/runs/3931078977
google_bigtable_instance - https://github.com/upbound/provider-gcp/actions/runs/3931154063
google_bigtable_table - https://github.com/upbound/provider-gcp/actions/runs/3931219599
The out of test resources:
google_bigtable_instance_iam_binding,
google_bigtable_instance_iam_member,
google_bigtable_table_iam_binding,
google_bigtable_table_iam_member
the
make runcommand doesn't creates yaml files for these resources.Also, the 'policy' resources from the issue are conflict:
cannot be used in conjunction with google_bigtable_*_iam_binding and google_bigtable_*_iam_member or they will fight over what your policy should be. In addition, be careful not to accidentally unset ownership of the instance as google_bigtable_*_iam_policy replaces the entire policy.