Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving activedirectory (1) resource to v1beta1 version #139

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

MyzaTaras
Copy link
Contributor

@MyzaTaras MyzaTaras commented Jan 18, 2023

Moving 1 resource to v1beta1 version

  • google_active_directory_domain

Description of your changes

Fixes #121

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual & Uptest:
google_active_directory_domain - link

@MyzaTaras MyzaTaras force-pushed the issue-121 branch 2 times, most recently from f2590e1 to 936bc38 Compare January 18, 2023 11:12
@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/activedirectory/domain.yaml"

@MyzaTaras MyzaTaras self-assigned this Jan 18, 2023
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyzaTaras LGTM!

@MyzaTaras MyzaTaras merged commit 42d0736 into crossplane-contrib:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving activedirectory (1) resource to v1beta1 version
2 participants