Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving memcache (1), mlengine (1), networkmanagement (1) resources to… #159

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

MyzaTaras
Copy link
Contributor

@MyzaTaras MyzaTaras commented Jan 20, 2023

Moving 1 resource to v1beta1 version:

  • google_memcache_instance

Moving 1 resource to v1beta1 version:

  • google_ml_engine_model

Moving 1 resource to v1beta1 version:

  • google_network_management_connectivity_test

Description of your changes

Fixes #152

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual and Uptest:
google_memcache_instance - link
google_ml_engine_model - link
google_network_management_connectivity_test - link

… v1beta1 version

Moving memcache:
- google_memcache_instance

Moving mlengine:
- google_ml_engine_model

Moving networkmanagement:
- google_network_management_connectivity_test
@MyzaTaras MyzaTaras self-assigned this Jan 20, 2023
@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/memcache/instance.yaml"

@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/mlengine/model.yaml"

@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/networkmanagement/connectivitytest.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyzaTaras LGTM!

@MyzaTaras MyzaTaras merged commit 8cde199 into crossplane-contrib:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving memcache (1), mlengine (1), networkmanagement (1) resources to v1beta1 version
2 participants