Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding google_vertex_ai_dataset, google_vertex_ai_featurestor, google_vertex_ai_featurestore_entitytype, google_vertex_ai_tensorboard, google_filestore_backup, google_filestore_snapshot to v1beta1 version #188

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

mykolalosev
Copy link
Contributor

@mykolalosev mykolalosev commented Jan 27, 2023

Description of your changes

Adding vertexai 4 resources to v1beta1 version

Adding filestore 2 resources to v1beta1 version

Fixes #183

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual & Uptest:

google_vertex_ai_dataset - https://github.com/upbound/provider-gcp/actions/runs/4025045310
google_vertex_ai_featurestore - https://github.com/upbound/provider-gcp/actions/runs/4025048451
google_vertex_ai_featurestore_entitytype - https://github.com/upbound/provider-gcp/actions/runs/4043534736
google_vertex_ai_tensorboard - https://github.com/upbound/provider-gcp/actions/runs/4025052545
google_filestore_backup - https://github.com/upbound/provider-gcp/actions/runs/4025042618
google_filestore_snapshot - https://github.com/upbound/provider-gcp/actions/runs/4025059535

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/filestore/backup.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/vertexai/dataset.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/vertexai/featurestore.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/vertexai/tensorboard.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/vertexai/featurestoreentitytype.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/filestore/snapshot.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/vertexai/featurestoreentitytype.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mykolalosev LGTM!

@mykolalosev mykolalosev merged commit 84407b1 into crossplane-contrib:main Jan 31, 2023
@mykolalosev mykolalosev deleted the issue-183 branch January 31, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving vertexai (4), filestore (2) resources to v1beta1 version
2 participants