Adding google_apigee_nat_address, google_artifact_registry_repository, google_beyondcorp_app_connection, google_beyondcorp_app_connector, google_beyondcorp_app_gateway, google_bigquery_analytics_hub_data_exchange, google_bigquery_analytics_hub_listing to v1beta1 version #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/bigquery/analyticshubdataexchange.yaml" |
|
/test-examples="examples/artifact/registryrepository.yaml" |
|
/test-examples="examples/beyondcorp/appconnector.yaml" |
|
/test-examples="examples/beyondcorp/appgateway.yaml" |
|
/test-examples="examples/bigquery/analyticshublisting.yaml" |
sergenyalcin
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding
apigee(1) resources to v1beta1 versionAdding
artifactregistry(1) resources to v1beta1 versionAdding
beyondcorp(3) resources to v1beta1 versionAdding
bigqueryanalyticshub(2) resources to v1beta1 versionFixes #173
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manual:
google_apigee_nat_address - An organization resource requires a real project ID
google_beyondcorp_app_connection - The resource requires a real Project ID
Manual & Uptest:
google_artifact_registry_repository - https://github.com/upbound/provider-gcp/actions/runs/4055433119
google_beyondcorp_app_connector - https://github.com/upbound/provider-gcp/actions/runs/4055438632
google_beyondcorp_app_gateway - https://github.com/upbound/provider-gcp/actions/runs/4055446952
google_bigquery_analytics_hub_data_exchange - https://github.com/upbound/provider-gcp/actions/runs/4055423814
google_bigquery_analytics_hub_listing - https://github.com/upbound/provider-gcp/actions/runs/4055511542