Add configurations of cloudplatform (5), iap (1), orgpolicy (1), tags (5), tpu (1), vpcaccess (1), workflows (1) groups #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Thanks @dverveiko I left a few comments that are related to required fields.
dverveiko
force-pushed
the
issue-162
branch
2 times, most recently
from
55411ad to
0b71c89
Compare
… (5), tpu (1), vpcaccess (1), workflows (1) groups
sergenyalcin
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add configuration of 5 resources in the
cloudplatformgroupgoogle_billing_subaccountgoogle_folder_organization_policygoogle_organization_policygoogle_project_iam_custom_rolegoogle_project_organization_policyAdd configuration of 1 resources in the
iapgroupgoogle_iap_tunnel_instance_iam_memberAdd configuration of 1 resources in the
orgpolicygroupgoogle_org_policy_policyAdd configuration of 5 resources in the
tagsgroupgoogle_tags_tag_keygoogle_tags_tag_key_iam_membergoogle_tags_tag_valuegoogle_tags_tag_value_iam_membergoogle_tags_tag_bindingAdd configuration of 1 resources in the
tpugroupgoogle_tpu_nodeAdd configuration of 1 resources in the
vpcaccessgroupgoogle_vpc_access_connectorAdd configuration of 1 resources in the
workflowsgroupgoogle_workflows_workflowFixes #162
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested