Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving cloudplatform(1) resource to v1beta1 version #224

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

MyzaTaras
Copy link
Contributor

@MyzaTaras MyzaTaras commented Feb 7, 2023

Description of your changes

Moving 1 resource to v1beta1 version

Fixes #213

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual:
google_project_iam_custom_role - due to account for Uptest running doesn't have permission for role creation.
Screenshot 2023-02-08 at 11 22 22

@MyzaTaras MyzaTaras self-assigned this Feb 7, 2023
@MyzaTaras MyzaTaras force-pushed the issue-213 branch 3 times, most recently from 9c2c646 to 0acb3f0 Compare February 8, 2023 08:32
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyzaTaras

@MyzaTaras MyzaTaras merged commit 9056af1 into crossplane-contrib:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving cloudplatform(1) resource to v1beta1 version
2 participants