Fix panic on DatabaseInstance failing to create #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases when a DatabaseInstance fails to create, such as when it cannot create a subnetwork, a panic would occur as there's no certificate info in the certSlice. Signed-off-by: Deniz Zoeteman <dkzoeteman@gmail.com>
dzoeteman
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
|
|
/test-examples="examples/sql/instance.yaml" |
turkenf
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In some cases when a DatabaseInstance fails to create, such as when it cannot create a subnetwork if there's no IP space available, a panic would occur as there's no certificate info in the certSlice. Fixed this by just checking if the certSlice is empty.
Fixes #343
I have:
make reviewable testto ensure this PR is ready for review. (just ranmake testas the rest fails)How has this code been tested
Tested the following scenarios:
status.atProvider.serverCaCertstatus.atProvider.serverCaCert. Status condition is still added with the error from GCP.