Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upjet to commit bd528e443b6f #367

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Aug 18, 2023

Description of your changes

Bumps upjet to commit bd528e443b6f.
Bumps the Terraform CLI to v1.5.5 and consumes the Terraform CLI from https://github.com/upbound/terraform/releases.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Via uptest

- Consume the Terraform CLI from https://github.com/upbound/terraform/releases

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

@ulucinar ulucinar force-pushed the bump-upjet-bd528e443b6f branch from 32db7ca to 6a2e859 Compare August 18, 2023 15:36
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar force-pushed the bump-upjet-bd528e443b6f branch from 6a2e859 to 09a9d41 Compare August 18, 2023 15:42
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/cloudplatform/serviceaccount.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar, LGTM.

@ulucinar ulucinar merged commit 2664f57 into crossplane-contrib:main Aug 18, 2023
@ulucinar ulucinar deleted the bump-upjet-bd528e443b6f branch August 18, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants