-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add google vpc access connector #391
Feature/add google vpc access connector #391
Conversation
0c77717
to
d9ef2ac
Compare
/test-examples="examples/vpcaccess/connector.yaml" |
1 similar comment
/test-examples="examples/vpcaccess/connector.yaml" |
7c231ad
to
56aad43
Compare
/test-examples="examples/vpcaccess/connector.yaml" |
Not sure why uptest is failing. I applied the same example to a local Kind cluster and the example network and vpc access connector came up fine. |
You can check by downloading the controlplane-dump file and opening the provider logs. Open the uptest job > scroll down the page and click on controlplane-dump > click on the upbound-system file > click on the provider-gcp-monolith-provider-gcp-... file. It says:
|
Is there an API or IAM permission that needs to be granted in the testing project? I don't seem to get this error in the project I have tested. |
/test-examples="examples/vpcaccess/connector.yaml" |
1 similar comment
/test-examples="examples/vpcaccess/connector.yaml" |
@bradkwadsworth-mw, if the uptest run fails again, you can check the logs, and the issue with the secret/permission is solved. |
Seeing this error in the log:
|
/test-examples="examples/vpcaccess/connector.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort in this PR @bradkwadsworth-mw, I left two small comments for you to consider.
/test-examples="examples/vpcaccess/connector.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bradkwadsworth-mw, LGTM.
Description of your changes
Added
google_vpc_access_connector
. Adding this resource required thecloud_run.service
reference ingoogle_compute_region_network_endpoint_group
to be disabled because of an import cycle error.Fixes #218 #162
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Applied to a local Kind cluster.