Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for family providers #395

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Sep 26, 2023

Description of your changes

This PR adds documentation for family providers

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

docs/family/Quickstart.md Outdated Show resolved Hide resolved
docs/family/Quickstart.md Outdated Show resolved Hide resolved
docs/family/Quickstart.md Show resolved Hide resolved
@turkenf turkenf marked this pull request as ready for review September 26, 2023 12:50
@turkenf turkenf force-pushed the add-family-docs branch 2 times, most recently from 2f3f5db to 332d968 Compare September 26, 2023 15:24
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort @turkenf. I left a few comments.

docs/monolith/Configuration.md Outdated Show resolved Hide resolved
docs/family/Quickstart.md Show resolved Hide resolved
docs/monolith/Quickstart.md Outdated Show resolved Hide resolved
docs/monolith/Quickstart.md Outdated Show resolved Hide resolved
docs/monolith/Quickstart.md Outdated Show resolved Hide resolved
docs/monolith/Quickstart.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@turkenf turkenf merged commit 2e7701d into crossplane-contrib:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants