-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added folder_sink resources #423
added folder_sink resources #423
Conversation
4aae033
to
eb12e3f
Compare
/test-examples="examples/logging/folderbucketconfig.yaml,examples/logging/folderexclusion.yaml,examples/logging/foldersink.yaml" |
/test-examples="examples/logging/folderbucketconfig.yaml,examples/logging/folderexclusion.yaml,examples/logging/foldersink.yaml" |
/test-examples="examples/logging/folderbucketconfig.yaml,examples/logging/folderexclusion.yaml,examples/logging/foldersink.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bradkwadsworth-mw, I left a few comments for you to consider.
Additionally, you do not need to trigger automatic tests for resources that require manual intervention, as they are skipped.
@bradkwadsworth-mw, could you please fix lint issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contributions here @bradkwadsworth-mw, LGTM.
Description of your changes
Added
google_logging_folder_bucket_config
,google_logging_folder_exclusion
, andgoogle_logging_folder_sink
. Also added aExtractFolderID
to thecommon
package.Adds the above resources found in this issue: #177
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Local Kind cluster