Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added folder_sink resources #423

Conversation

bradkwadsworth-mw
Copy link
Contributor

@bradkwadsworth-mw bradkwadsworth-mw commented Nov 16, 2023

Description of your changes

Added google_logging_folder_bucket_config, google_logging_folder_exclusion, and google_logging_folder_sink. Also added a ExtractFolderID to the common package.

Adds the above resources found in this issue: #177

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Local Kind cluster
Screenshot 2023-11-16 at 11 31 16 AM

@bradkwadsworth-mw bradkwadsworth-mw force-pushed the feature/add-folder-sink-resources branch from 4aae033 to eb12e3f Compare November 16, 2023 18:02
@bradkwadsworth-mw
Copy link
Contributor Author

/test-examples="examples/logging/folderbucketconfig.yaml,examples/logging/folderexclusion.yaml,examples/logging/foldersink.yaml"

@bradkwadsworth-mw
Copy link
Contributor Author

/test-examples="examples/logging/folderbucketconfig.yaml,examples/logging/folderexclusion.yaml,examples/logging/foldersink.yaml"

@bradkwadsworth-mw
Copy link
Contributor Author

/test-examples="examples/logging/folderbucketconfig.yaml,examples/logging/folderexclusion.yaml,examples/logging/foldersink.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bradkwadsworth-mw, I left a few comments for you to consider.

Additionally, you do not need to trigger automatic tests for resources that require manual intervention, as they are skipped.

config/common/config.go Show resolved Hide resolved
examples/logging/folderbucketconfig.yaml Outdated Show resolved Hide resolved
examples/logging/folderbucketconfig.yaml Outdated Show resolved Hide resolved
examples/logging/folderexclusion.yaml Outdated Show resolved Hide resolved
examples/logging/folderexclusion.yaml Outdated Show resolved Hide resolved
examples/logging/foldersink.yaml Outdated Show resolved Hide resolved
examples/logging/foldersink.yaml Outdated Show resolved Hide resolved
examples/logging/foldersink.yaml Show resolved Hide resolved
examples/logging/projectexclusion.yaml Outdated Show resolved Hide resolved
@turkenf
Copy link
Collaborator

turkenf commented Nov 20, 2023

@bradkwadsworth-mw, could you please fix lint issue:

config/logging/config.go:4: File is not `goimports`-ed with -local github.com/upbound/provider-gcp (goimports)
	"github.com/crossplane/upjet/pkg/config"
11:37:58 [FAIL]
make[1]: *** [go.lint] Error 1
make: *** [lint] Error 2

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contributions here @bradkwadsworth-mw, LGTM.

@turkenf turkenf merged commit 0137247 into crossplane-contrib:main Nov 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants