Make not-generated Terraform resources CSV available as a Github workflow artifact #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow artifact Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…nerator - Consume upjet commit 6de200a3a8b0ac77c5f9d122f93db26aacd61960 Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
turkenh
reviewed
Nov 14, 2022
| # to save a skipped resource list | ||
| SKIPPED_RESOURCES_CSV: ../_output/skipped_resources.csv | ||
|
|
||
| - name: Publish skipped resources CSV to Github |
There was a problem hiding this comment.
I believe this better fits publish-artifacts job below rather than check-diff. What do you think @ulucinar ?
There was a problem hiding this comment.
I agree. Unfortunately, the make build.all does not currently call the generate target and I did not want to introduce an extra make generate call that would make the workflows a little bit longer. I've discussed it here.
turkenh
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a change where a CSV file of Terraform resource names which are available in the Terraform provider's schema but not generated as managed resources is produced and made available as a Github workflow artifact.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested with the following workflow run:
https://github.com/upbound/provider-gcp/actions/runs/3439134516
https://github.com/upbound/provider-gcp/actions/runs/3461113867